Code checking -

cfg_grades.php

@@ -76,7 +76,7 @@ if ($_POST["action"] == "update") {
             }
 
         } else {
-            $scalecfg = (object)[ "scale_id" => $scale->id, ];
+            $scalecfg = (object)[ "scale_id" => $scale->id];
             $requireinsert = false;
             foreach (["min_progress", "min_completed"] as $handle) {
                 $key = "s_{$scale->id}_{$handle}";
@@ -154,8 +154,8 @@ foreach ($scales as $scale) {
         $scalecfg = $scalecfgs[$scale->id];
     }
 
-    $attrsc = ['value' => '', 'disabled' => 'disabled', ];
+    $attrsc = ['value' => '', 'disabled' => 'disabled'];
-    $attrsp = ['value' => '', 'disabled' => 'disabled', ];
+    $attrsp = ['value' => '', 'disabled' => 'disabled'];
 
     if (!isset($scalecfg) || $scalecfg->min_completed == "") {
         $attrsc["selected"] = "selected";
@@ -198,7 +198,7 @@ foreach ($scales as $scale) {
     $data[] = $row;
 }
 
-print html_writer::start_tag("form", ["method" => "post", ]);
+print html_writer::start_tag("form", ["method" => "post"]);
 print html_writer::tag("input", null, ['name' => "action", 'value' => 'update', 'type' => 'hidden']);
 
 $table = new html_table();
@@ -227,7 +227,7 @@ foreach ($gradecfgs as $g) {
                                 'autocomplete' => 'off']);
     $row[] = html_writer::tag("input",
                               null,
-                              ['name' => "g_{$g->grade_points}_delete", 'type' => 'checkbox', ]);
+                              ['name' => "g_{$g->grade_points}_delete", 'type' => 'checkbox']);
     $data[] = $row;
 }
 

classes/aggregator.php

@@ -23,7 +23,7 @@
 namespace local_treestudyplan;
 
 use moodle_exception;
-use \ValueError;
+use ValueError;
 
 defined('MOODLE_INTERNAL') || die();
 

classes/badgeinfo.php

@@ -26,7 +26,7 @@ defined('MOODLE_INTERNAL') || die();
 require_once($CFG->libdir.'/externallib.php');
 
 use award_criteria;
-use \core_badges\badge;
+use core_badges\badge;
 use moodle_url;
 
 /**

classes/cascadecohortsync.php

@@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->libdir.'/externallib.php');
 
-use \local_treestudyplan\studyplan;
+use local_treestudyplan\studyplan;
 
 /**
  * Task class to synchronize enrolled cohorts in courses with cohorts associated with studyplans these courses are in

classes/cascadeusersync.php

@@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->libdir.'/externallib.php');
 
-use \local_treestudyplan\studyplan;
+use local_treestudyplan\studyplan;
 
 /**
  * Task class to synchronize enrolled users in courses with users associated with studyplans these courses are in

classes/completionscanner.php

@@ -25,8 +25,8 @@ defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->libdir.'/externallib.php');
 
-use \grade_item;
+use grade_item;
-use \completion_criteria;
+use completion_criteria;
 
 /**
  * Scan course completion criteria for pending grading actions

classes/contextinfo.php

@@ -21,7 +21,7 @@
  */
 
 namespace local_treestudyplan;
-use \context;
+use context;
 
 /**
  * Class to abstract information about (category) context for web service export

classes/corecompletioninfo.php

@@ -30,9 +30,9 @@ require_once($CFG->dirroot.'/course/lib.php');
 use core\check\performance\debugging;
 use core_course\local\repository\caching_content_item_readonly_repository;
 use core_course\local\repository\content_item_readonly_repository;
-use \grade_item;
+use grade_item;
-use \grade_scale;
+use grade_scale;
-use \grade_outcome;
+use grade_outcome;
 
 /**
  * Class to collect course completion info for a given course

classes/courseinfo.php

@@ -29,9 +29,9 @@ require_once($CFG->dirroot.'/course/lib.php');
 
 use core_course\local\repository\caching_content_item_readonly_repository;
 use core_course\local\repository\content_item_readonly_repository;
-use \grade_item;
+use grade_item;
-use \grade_scale;
+use grade_scale;
-use \grade_outcome;
+use grade_outcome;
 
 /**
  * Class to process information about a course

classes/courseservice.php

@@ -25,13 +25,13 @@ defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->libdir.'/externallib.php');
 
-use \local_treestudyplan\courseinfo;
+use local_treestudyplan\courseinfo;
-use \local_treestudyplan\associationservice;
+use local_treestudyplan\associationservice;
-use \local_treestudyplan\local\helpers\webservicehelper;
+use local_treestudyplan\local\helpers\webservicehelper;
-use \local_treestudyplan\completionscanner;
+use local_treestudyplan\completionscanner;
-use \local_treestudyplan\gradingscanner;
+use local_treestudyplan\gradingscanner;
-use \local_treestudyplan\debug;
+use local_treestudyplan\debug;
-use \core_course_category;
+use core_course_category;
 use moodle_exception;
 
 /**

classes/gradeinfo.php

@@ -30,10 +30,10 @@ require_once($CFG->dirroot.'/course/lib.php');
 use core_course\local\repository\caching_content_item_readonly_repository;
 use core_course\local\repository\content_item_readonly_repository;
 use core_course\local\entity\content_item;
-use \grade_item;
+use grade_item;
-use \grade_scale;
+use grade_scale;
-use \grade_outcome;
+use grade_outcome;
-use \core_plugin_manager;
+use core_plugin_manager;
 /**
  * Collect, process and display information about gradable items
  */

classes/gradingscanner.php

@@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->libdir.'/externallib.php');
 
-use \grade_item;
+use grade_item;
 
 /**
  * Scan gradables for a pending grading action

classes/local/aggregators/bistate_aggregator.php

@@ -22,10 +22,10 @@
 
 namespace local_treestudyplan\local\aggregators;
 
-use \local_treestudyplan\courseinfo;
+use local_treestudyplan\courseinfo;
-use \local_treestudyplan\gradeinfo;
+use local_treestudyplan\gradeinfo;
-use \local_treestudyplan\studyitem;
+use local_treestudyplan\studyitem;
-use \local_treestudyplan\completion;
+use local_treestudyplan\completion;
 
 /**
  * Aggregate course results based on failed/completed states for grades

classes/local/aggregators/competency_aggregator.php

@@ -24,10 +24,10 @@ namespace local_treestudyplan\local\aggregators;
 
 use core_competency\api as c_api;
 
-use \local_treestudyplan\courseinfo;
+use local_treestudyplan\courseinfo;
-use \local_treestudyplan\gradeinfo;
+use local_treestudyplan\gradeinfo;
-use \local_treestudyplan\studyitem;
+use local_treestudyplan\studyitem;
-use \local_treestudyplan\completion;
+use local_treestudyplan\completion;
 use local_treestudyplan\coursecompetencyinfo;
 
 /**

classes/local/aggregators/core_aggregator.php

@@ -22,11 +22,11 @@
 
 namespace local_treestudyplan\local\aggregators;
 
-use \local_treestudyplan\courseinfo;
+use local_treestudyplan\courseinfo;
-use \local_treestudyplan\corecompletioninfo;
+use local_treestudyplan\corecompletioninfo;
-use \local_treestudyplan\gradeinfo;
+use local_treestudyplan\gradeinfo;
-use \local_treestudyplan\studyitem;
+use local_treestudyplan\studyitem;
-use \local_treestudyplan\completion;
+use local_treestudyplan\completion;
 
 /**
  * Aggregate course results with moodle course completion

classes/local/aggregators/tristate_aggregator.php

@@ -22,10 +22,10 @@
 
 namespace local_treestudyplan\local\aggregators;
 
-use \local_treestudyplan\courseinfo;
+use local_treestudyplan\courseinfo;
-use \local_treestudyplan\gradeinfo;
+use local_treestudyplan\gradeinfo;
-use \local_treestudyplan\studyitem;
+use local_treestudyplan\studyitem;
-use \local_treestudyplan\completion;
+use local_treestudyplan\completion;
 
 /**
  * Aggregate course results based on failed, achieved, completed states for grades

classes/local/helpers/webservicehelper.php

@@ -21,7 +21,7 @@
  */
 
 namespace local_treestudyplan\local\helpers;
-use \core_course_category;
+use core_course_category;
 use local_treestudyplan\courseservice;
 use local_treestudyplan\debug;
 

classes/local/ungradedscanners/scanner_base.php

@@ -22,7 +22,7 @@
 
 namespace local_treestudyplan\local\ungradedscanners;
 
-use \grade_item;
+use grade_item;
 
 /**
  * Base class for activity scanners

classes/privacy/provider.php

@@ -22,17 +22,17 @@
 
 namespace local_treestudyplan\privacy;
 
-use \core_privacy\local\metadata\collection;
+use core_privacy\local\metadata\collection;
-use \core_privacy\local\request\userlist;
+use core_privacy\local\request\userlist;
-use \core_privacy\local\request\contextlist;
+use core_privacy\local\request\contextlist;
-use \core_privacy\local\request\approved_contextlist;
+use core_privacy\local\request\approved_contextlist;
-use \core_privacy\local\request\approved_userlist;
+use core_privacy\local\request\approved_userlist;
-use \core_privacy\local\request\deletion_criteria;
+use core_privacy\local\request\deletion_criteria;
-use \core_privacy\local\request\writer;
+use core_privacy\local\request\writer;
-use \core_privacy\local\request\helper;
+use core_privacy\local\request\helper;
-use \core_privacy\local\request\transform;
+use core_privacy\local\request\transform;
-use \tool_dataprivacy\context_instance;
+use tool_dataprivacy\context_instance;
-use \context;
+use context;
 
 /**
  * Privacy provider

classes/studentstudyplanservice.php

@@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->libdir.'/externallib.php');
 
-use \local_treestudyplan\local\helpers\webservicehelper;
+use local_treestudyplan\local\helpers\webservicehelper;
 use local_treestudyplan\task\autocohortsync;
 
 require_once($CFG->libdir.'/badgeslib.php');

cli/generate_badges.php

@@ -25,7 +25,7 @@ namespace local_treestudyplan;
 define('CLI_SCRIPT', true);
 require(__DIR__ . '/../../../config.php');
 require_once($CFG->libdir . '/clilib.php');
-use \core_badges\badge;
+use core_badges\badge;
 use local_treestudyplan\local\randomimage;
 require_once($CFG->libdir.'/badgeslib.php');
 

cli/prime_students.php

@@ -22,7 +22,7 @@
 
 namespace local_treestudyplan;
 
-use \local_treestudyplan\local\gradegenerator;
+use local_treestudyplan\local\gradegenerator;
 
 define('CLI_SCRIPT', true);
 require(__DIR__ . '/../../../config.php');

cli/randomize_grades.php

@@ -22,7 +22,7 @@
 
 namespace local_treestudyplan;
 
-use \local_treestudyplan\local\gradegenerator;
+use local_treestudyplan\local\gradegenerator;
 
 define('CLI_SCRIPT', true);
 require(__DIR__ . '/../../../config.php');

coach.php

@@ -22,7 +22,7 @@
 
 require_once("../../config.php");
 
-use \local_treestudyplan\premium;
+use local_treestudyplan\premium;
 
 require_once($CFG->libdir.'/weblib.php');
 

edit-plan.php

@@ -24,10 +24,10 @@ require_once("../../config.php");
 
 require_once($CFG->libdir.'/weblib.php');
 
-use \local_treestudyplan\contextinfo;
+use local_treestudyplan\contextinfo;
-use \local_treestudyplan\studyplan;
+use local_treestudyplan\studyplan;
-use \local_treestudyplan\courseservice;
+use local_treestudyplan\courseservice;
-use \local_treestudyplan\debug;
+use local_treestudyplan\debug;
 
 $systemcontext = context_system::instance();
 

lang/en/local_treestudyplan.php

@@ -488,10 +488,9 @@ $string["setting_premium_heading"] = 'Premium features';
 $string["settingdesc_premium_heading"] = 'To access premium features, you need a registration key.
 <br>Premium features include:
 <ul>
-<li>Creating more than 5 studyplans per category</li>
+<li>Overview of grades for all students in a studyplan.</li>
-<li>Creating studyplans in more than 20 categories</li>
+<li>Rows in a studyplan which a student can choose to unlock.</li>
-<li>Overview of grades for all students in a studyplan</li>
+<li>Coach role, which allows a linked coach to follow student progress and limited options to make changes to the studyplan content.</li>
-<li>Rows in a studyplan which a student can choose to unlock</li>
 </ul>';
 $string["setting_premium_status"] = 'Current premium status';
 $string["setting_premium_key"] = 'Activation key';

lang/nl/local_treestudyplan.php

@@ -490,10 +490,9 @@ $string["setting_premium_heading"] = 'Premium features';
 $string["settingdesc_premium_heading"] = 'Voor premium toegang is een activeringssleutel vereist.
 <br>Premium toegang bevat onder andere:
 <ul>
-<li>Meer dan 5 studieplannen per categorie aan kunnen maken</li>
+<li>Overzichtsrapport van alle resultaten van studenten in een studieplan.</li>
-<li>In meer dan 20 categorieën studieplannen kunnen aanmaken</li>
+<li>Leerlijnen die student kan ontsluiten.</li>
-<li>Overzichtsrapport van alle resultaten van studenten in een studieplan</li>
+<li>Coach rol, waarbij een coach gekoppeld kan worden aan een studieplan, de voortgang van studenten hierin kan volgen en de inhoud hiervan beperkt kan aanpassen.</li>
-<li>Leerlijnen die student kan ontsluiten</li>
 </ul>';
 $string["setting_premium_status"] = 'Premium status';
 $string["setting_premium_key"] = 'Activatiesleutel';

lib.php

@@ -25,7 +25,7 @@
 
 use local_treestudyplan\local\helpers\webservicehelper;
 use local_treestudyplan\premium;
-use \local_treestudyplan\studyplan;
+use local_treestudyplan\studyplan;
 use local_treestudyplan\studyplanpage;
 
 /**

result-overview.php

@@ -23,10 +23,10 @@
 require_once("../../config.php");
 
 use local_treestudyplan\contextinfo;
-use \local_treestudyplan\courseservice;
+use local_treestudyplan\courseservice;
-use \local_treestudyplan\studyplan;
+use local_treestudyplan\studyplan;
-use \local_treestudyplan\studyplanpage;
+use local_treestudyplan\studyplanpage;
-use \local_treestudyplan\premium;
+use local_treestudyplan\premium;
 
 require_once($CFG->libdir.'/weblib.php');
 

view-plan.php

@@ -23,7 +23,7 @@
 require_once("../../config.php");
 
 use local_treestudyplan\contextinfo;
-use \local_treestudyplan\courseservice;
+use local_treestudyplan\courseservice;
 
 require_once($CFG->libdir.'/weblib.php');