Tweaks

coach.php

@@ -48,23 +48,12 @@ if ($CFG->debugdeveloper) {
 }
 $PAGE->requires->js_call_amd('local_treestudyplan/page-coach', 'init', []);
 
-/**
- * Shortcut function to provide translations
- * @param mixed $str Translation key
- * @param null|string[] $param Parameters to pass to translation
- * @param string $plugin Location to search for translation strings
- * @return string Translation of key
- */
-function t($str, $param = null, $plugin = 'local_treestudyplan') {
-    print get_string($str, $plugin, $param);
-}
-
 print $OUTPUT->header();
 $text = (object)[
-    'studyplan_select' => t("studyplan_select"),
+    'studyplan_select' => get_string("studyplan_select", 'local_treestudyplan'),
-    'coacheditmode' => t("coacheditmode"),
+    'coacheditmode' => get_string("coacheditmode", 'local_treestudyplan'),
-    'showoverview' => t("showoverview"),
+    'showoverview' => get_string("showoverview", 'local_treestudyplan'),
-    'studyplan_noneselected' => t("studyplan_noneselected"),
+    'studyplan_noneselected' => get_string("studyplan_noneselected", 'local_treestudyplan'),
 ];
 
 print <<<END

edit-plan.php

@@ -106,23 +106,11 @@ $PAGE->requires->js_call_amd('local_treestudyplan/page-edit-plan', 'init', [$stu
     "defaultAggregation" => get_config("local_treestudyplan", "aggregation_mode"),
 ]]);
 
-/**
- * Shortcut function to provide translations
- *
- * @param mixed $str Translation key
- * @param null|string[] $param Parameters to pass to translation
- * @param string $plugin Location to search for translation strings
- * @return string Translation of key
- */
-function t($str, $param = null, $plugin = 'local_treestudyplan') {
-    print get_string($str, $plugin, $param);
-}
-
 print $OUTPUT->header();
 $text = (object)[
-    'loading' => t("loading", null, "core"),
+    'loading' => get_string("loading", "core"),
-    'studyplan_select' => t("studyplan_select"),
+    'studyplan_select' => get_string("studyplan_select", 'local_treestudyplan'),
-    'studyplan_noneselected' => t("studyplan_noneselected"),
+    'studyplan_noneselected' => get_string("studyplan_noneselected", 'local_treestudyplan'),
 ];
 
 print <<<END

invited.php

@@ -23,17 +23,6 @@
 require_once("../../config.php");
 // Since this page is externally accessed and validated in a different way, no login is needed.
 
-/**
- * Shortcut function to provide translations
- *
- * @param mixed $str Translation key
- * @param null|string[] $param Parameters to pass to translation
- * @param string $plugin Location to search for translation strings
- * @return string Translation of key
- */
-function t($str, $param = null, $plugin = 'local_treestudyplan') {
-    print get_string($str, $plugin, $param);
-}
 
 $systemcontext = context_system::instance();
 $PAGE->set_pagelayout('base');

myreport.php

@@ -53,18 +53,6 @@ if ($CFG->debugdeveloper) {
 }
 $PAGE->requires->js_call_amd('local_treestudyplan/page-myreport', 'init', [$amteaching ? 'teaching' : 'own']);
 
-/**
- * Shortcut function to provide translations
- *
- * @param mixed $str Translation key
- * @param null|string[] $param Parameters to pass to translation
- * @param string $plugin Location to search for translation strings
- * @return string Translation of key
- */
-function t($str, $param = null, $plugin = 'local_treestudyplan') {
-    print get_string($str, $plugin, $param);
-}
-
 print $OUTPUT->header();
 
 print '<div class="m-buttonbar" style="margin-bottom: 1em; text-align: right;">';

result-overview.php

@@ -66,18 +66,6 @@ $PAGE->requires->js_call_amd(
     [$studyplan->id(), $page->id(), $firstperiod, $lastperiod]
 );
 
-/**
- * Shortcut function to provide translations
- *
- * @param mixed $str Translation key
- * @param null|string[] $param Parameters to pass to translation
- * @param string $plugin Location to search for translation strings
- * @return string Translation of key
- */
-function t($str, $param = null, $plugin = 'local_treestudyplan') {
-    print get_string($str, $plugin, $param);
-}
-
 print $OUTPUT->header();
 print "<h3><b>{$contextname}</b> / {$studyplan->name()}</h3>";
 if ($studyplan->name() != $page->fullname()) {

view-plan.php

@@ -104,26 +104,14 @@ if ($CFG->debugdeveloper) {
 }
 $PAGE->requires->js_call_amd('local_treestudyplan/page-view-plan', 'init', [$studyplancontext->id, $categoryid]);
 
-/**
- * Shortcut function to provide translations
- *
- * @param mixed $str Translation key
- * @param null|string[] $param Parameters to pass to translation
- * @param string $plugin Location to search for translation strings
- * @return string Translation of key
- */
-function t($str, $param = null, $plugin = 'local_treestudyplan') {
-    print get_string($str, $plugin, $param);
-}
-
 print $OUTPUT->header();
 $text = (object)[
-    'loading' => t("loading", null, "core"),
+    'loading' => get_string("loading", "core"),
-    'back' => t('back'),
+    'back' => get_string('back', 'local_treestudyplan'),
-    'studyplan_select' => t("studyplan_select"),
+    'studyplan_select' => get_string("studyplan_select", 'local_treestudyplan'),
-    'selectstudent_btn' => t('selectstudent_btn'),
+    'selectstudent_btn' => get_string('selectstudent_btn', 'local_treestudyplan'),
-    'showoverview' => t("showoverview"),
+    'showoverview' => get_string("showoverview", 'local_treestudyplan'),
-    'studyplan_noneselected' => t("studyplan_noneselected"),
+    'studyplan_noneselected' => get_string("studyplan_noneselected", 'local_treestudyplan'),
 ];
 print <<<END
 <div id='root'>