Code cleanup and minor ui fixes

amd/src/report-viewer-components.js

@@ -2919,7 +2919,7 @@ export default {
                                 ><i class='fa fa-asterisk' ></i
                             ></abbr>
                         </td>
-                        <td><r-completion-bar v-model="c.completionstats" :width="150" :height="15"></td>
+                        <td><r-completion-bar v-model="c.completionstats" :width="150" :height="15"></r-completion-bar></td>
                         <td v-if="c.feedback">
                             <a  v-b-modal="'r-competency-feedback-'+c.id"
                                 href="#"

amd/src/studyplan-editor-components.js

@@ -1044,9 +1044,7 @@ export default {
                 coachDisassociate() {
                     if (premiumenabled()) {
                         const self = this;
-                        const associated = self.association.coaches;
                         const associatedselected = self.selected.associated.coaches;
-                        const search = self.search.coaches;
                         for (const i in associatedselected) {
                             const r = associatedselected[i];
 
@@ -1056,10 +1054,7 @@ export default {
                                     'studyplan_id': self.value.id,
                                     'user_id': r,
                                 }
-                            }])[0].then((response) => {
+                            }])[0].then(() => {
-                                if (response.success) {
-                                    transportItem(search, associated, r);
-                                }
                                 return;
                             }).catch(notification.exception);
                         }

amd/src/treestudyplan-components.js

@@ -435,7 +435,10 @@ export default {
                         <span v-else-if='field.type == "checkbox"' 
                         :class="'value ' + (field.checked?'true':'false')">{{ field.value }}</span>
                         <span v-else-if='field.type == "textarea"'>
-                            <a class='text-info' href='#' v-b-modal="field.courseid+'_'+field.fieldname">{{text.show}}...</a>
+                            <a  class='text-info' 
+                                @click.prevent.stop=""
+                                href='#' 
+                                v-b-modal="field.courseid+'_'+field.fieldname">{{text.show}}...</a>
                             <b-modal
                                 :id="field.courseid+'_'+field.fieldname"
                                 :title="field.title""

classes/gradeinfo.php

@@ -121,7 +121,7 @@ class gradeinfo {
     protected static function get_contentitems(): array {
         global $PAGE;
         if (empty(static::$contentitems)) {
-            if(empty($PAGE->context)) {
+            if (empty($PAGE->context)) {
                 $PAGE->set_context(\context_system::instance());
             }
             static::$contentitems = (new content_item_readonly_repository())->find_all();