From ecd47829e12c4caaac0bad8e0779033d3d52f2bc Mon Sep 17 00:00:00 2001 From: PMKuipers Date: Sat, 26 Aug 2023 16:51:35 +0200 Subject: [PATCH] Code style tweaks --- classes/associationservice.php | 2 +- classes/local/ungradedscanners/assign_scanner.php | 4 ++-- classes/local/ungradedscanners/quiz_scanner.php | 4 ++-- version.php | 7 +++---- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/classes/associationservice.php b/classes/associationservice.php index f64f00d..627527e 100644 --- a/classes/associationservice.php +++ b/classes/associationservice.php @@ -414,7 +414,7 @@ class associationservice extends \external_api { WHERE tc.studyplan_id = :studyplanid OR tu.studyplan_id = :studyplanidtoo ORDER BY u.lastname, u.firstname"; - $rs = $DB->get_recordset_sql($sql,["studyplanid" => $studyplan->id(), "studyplanidtoo" => $studyplan->id()]); + $rs = $DB->get_recordset_sql($sql, ["studyplanid" => $studyplan->id(), "studyplanidtoo" => $studyplan->id()]); foreach ($rs as $u) { $users[] = self::make_user_model($u); diff --git a/classes/local/ungradedscanners/assign_scanner.php b/classes/local/ungradedscanners/assign_scanner.php index 1bb5e35..5295301 100644 --- a/classes/local/ungradedscanners/assign_scanner.php +++ b/classes/local/ungradedscanners/assign_scanner.php @@ -37,7 +37,7 @@ class assign_scanner extends scanner_base { AND a.grade <> 0 AND (ag.id IS NULL OR asgn_sub.timemodified >= ag.timemodified) "; - return $DB->get_fieldset_sql($sql,['iteminstance' => $this->gi->iteminstance]); + return $DB->get_fieldset_sql($sql, ['iteminstance' => $this->gi->iteminstance]); } protected function get_graded_users() { @@ -47,7 +47,7 @@ class assign_scanner extends scanner_base { LEFT JOIN {grade_items} gi on g.itemid = gi.id WHERE gi.itemmodule = 'assign' AND gi.iteminstance = :iteminstance AND g.finalgrade IS NOT NULL"; // MAy turn out to be needed, dunno. - return $DB->get_fieldset_sql($sql,['iteminstance' => $this->gi->iteminstance]); + return $DB->get_fieldset_sql($sql, ['iteminstance' => $this->gi->iteminstance]); } public function count_ungraded($courseuserids = []) { diff --git a/classes/local/ungradedscanners/quiz_scanner.php b/classes/local/ungradedscanners/quiz_scanner.php index 5164afd..5fa641b 100644 --- a/classes/local/ungradedscanners/quiz_scanner.php +++ b/classes/local/ungradedscanners/quiz_scanner.php @@ -39,7 +39,7 @@ class quiz_scanner extends scanner_base { JOIN {quiz_attempts} qza ON qna.questionusageid = qza.uniqueid WHERE qas.state = 'needsgrading' AND qza.quiz = :iteminstance"; - $rs = $DB->get_recordset_sql($sql,['iteminstance' => $this->gi->iteminstance]); + $rs = $DB->get_recordset_sql($sql, ['iteminstance' => $this->gi->iteminstance]); $submissions = []; foreach ($rs as $r) { // Now, check if . @@ -72,7 +72,7 @@ class quiz_scanner extends scanner_base { WHERE gi.itemmodule = 'quiz' AND gi.iteminstance = :iteminstance AND g.finalgrade IS NOT NULL"; // MAy turn out to be needed, dunno. - $graded = $DB->get_fieldset_sql($sql,['iteminstance' => $this->gi->iteminstance]); + $graded = $DB->get_fieldset_sql($sql, ['iteminstance' => $this->gi->iteminstance]); if (count($courseuserids) > 0) { $graded = array_intersect($graded, $courseuserids); diff --git a/version.php b/version.php index a66852a..50e400d 100644 --- a/version.php +++ b/version.php @@ -25,13 +25,12 @@ $plugin->component = 'local_treestudyplan'; // Recommended since 2.0.2 (MDL-260 $plugin->version = 2023082101; // YYYYMMDDHH (year, month, day, iteration). $plugin->requires = 2021051700; // YYYYMMDDHH (This is the release version for Moodle 3.11). -$plugin->release = "1.0.0"; +$plugin->release = "1.0.0"; $plugin->maturity = MATURITY_RC; -// Supported from Moodle 3.11 to 4.1 (4.2 not yet tested)/ + +// Supported from Moodle 3.11 to 4.1 (4.2 not yet tested). $plugin->supported = [ 311, 401 ]; $plugin->dependencies = [ 'theme_boost' => 2019052000, ]; - -