Miqra-Engineering/moodle_local_treestudyplan
2
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases 4 Wiki Activity

Replace .done(), .fail() etc with Native Promise followup ( .then() ) #1

New Issue
Closed
opened 2023-08-08 22:26:42 +02:00 by pmkuipers · 0 comments
pmkuipers commented 2023-08-08 22:26:42 +02:00
Owner
Copy Link

https://moodledev.io/docs/guides/javascript#promises

Indicates that

You shouldn't use the done, fail, or always functions on Promises. These are a jQuery feature which isn't present in the Native Promise implementation.

This should be replaced with proper .then responses.
We have been using .done() and .fail() on ajax calls....

https://moodledev.io/docs/guides/javascript#promises Indicates that > You shouldn't use the done, fail, or always functions on Promises. These are a jQuery feature which isn't present in the Native Promise implementation. This should be replaced with proper .then responses. We have been using .done() and .fail() on ajax calls....
pmkuipers added the
Kind
Deprecation issue
 label 2023-08-31 22:54:59 +02:00
pmkuipers added this to the Folluwup improvements milestone 2023-08-31 22:55:41 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Fixed
Confirmed
The issue has been fixed and the fix has been tested

  
Fixed
Unconfirmed
The issue has been fixed, but the fix needs more testing

  
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind
Deprecation issue
Address use of deprecated features in libraries

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Language
Issue is related to a typo or a need to reword text

  
Kind
Security
This is security issue

  
Priority
High

  
Priority
Low

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Fixed
Confirmed
Fixed
Unconfirmed
Kind
Breaking
Kind
Bug
Kind
Deprecation issue
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Language
Kind
Security
Priority
High
Priority
Low
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Folluwup improvements
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Miqra-Engineering/moodle_local_treestudyplan#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?