The lang files should only contain simple strings and not php code. #77

New Issue

danmarsden · 2024-10-21T22:23:40+02:00

danmarsden commented

2024-10-21 22:23:40 +02:00

code like this should not be in your lang string files:

https://git.miqra.nl/Miqra-Engineering/moodle_local_treestudyplan/src/branch/master/lang/en/local_treestudyplan.php#L144-L151

string concatenation and raw PHP in the lang packs is not allowed - it causes problems for the Moodle translation tool

eg:
$string['test'] = "sometext"."somemoretext";
or
$string['test'] = "sometext".$string['someotheritem'];

each string must be contained within one set of quotes eg:
$string['test'] = "sometext somemoretext";

code like this should not be in your lang string files: https://git.miqra.nl/Miqra-Engineering/moodle_local_treestudyplan/src/branch/master/lang/en/local_treestudyplan.php#L144-L151 string concatenation and raw PHP in the lang packs is not allowed - it causes problems for the Moodle translation tool eg: $string['test'] = "sometext"."somemoretext"; or $string['test'] = "sometext".$string['someotheritem']; each string must be contained within one set of quotes eg: $string['test'] = "sometext somemoretext";

pmkuipers self-assigned this 2024-10-29 09:20:28 +01:00

pmkuipers commented

2024-11-01 12:59:57 +01:00

Resolved in commit 108a612e8c by removing the PHP code and expanding the loop into multiple copies of the lines.

Resolved in commit 108a612e8c by removing the PHP code and expanding the loop into multiple copies of the lines.

pmkuipers closed this issue

2024-11-01 12:59:57 +01:00

Sign in to join this conversation.